fix: remove consumer-side Repository client WithCaching to prevent startup crash by frasermolyneux · Pull Request #53 · frasermolyneux/portal-server-events

frasermolyneux · 2026-08-02T21:17:28Z

Summary

Urgent preventive production hotfix. Removes consumer-side WithCaching(c => c.UseLibraryDefaults()) from the Repository API client registration in the Processor App so it does not hit the same startup crash that took down portal-sync and portal-repository-func.

portal-sync and portal-repository-func are currently crashing at startup with ArgumentException: expression must invoke a method declared by IAdminActionsApi... on Repository 4.2.21 client-side caching policy composition. main here (PR #52 / commit 28ab5f4) has the identical registration and is subject to the same deterministic failure on the next Function App restart.

Repository 4.2.21 / MX.Api 2.3.76 versions unchanged. Repository server-side caching remains active. Player-context IMemoryCache, LiveStatus.V1 writes, moderation, VPN protection, welcome messages, and all Service Bus event handling are untouched.

Closes #

Type of change

Required reading consulted

AGENTS.md (repo brief)
.github/copilot-instructions.md (repo orientation)
.github-copilot/.github/instructions/personal.working-preferences.instructions.md (always-on rules)
Stack-specific instruction files referenced in AGENTS.md (standards.*, patterns.*, platform.*, shared.*)

Validation evidence

Build

$ dotnet build src/XtremeIdiots.Portal.Server.Events.slnx
XtremeIdiots.Portal.Server.Events.Abstractions.V1 -> ...\XtremeIdiots.Portal.Server.Events.Abstractions.V1.dll
XtremeIdiots.Portal.Server.Events.Processor.App -> ...\XtremeIdiots.Portal.Server.Events.Processor.App.dll
XtremeIdiots.Portal.Server.Events.Processor.App.Tests -> ...\XtremeIdiots.Portal.Server.Events.Processor.App.Tests.dll

Build succeeded.
    0 Warning(s)
    0 Error(s)

Tests

Targeted (new startup DI test):

$ dotnet test src/XtremeIdiots.Portal.Server.Events.slnx --filter "FullyQualifiedName~RepositoryApiClientRegistrationTests"
Passed!  - Failed:     0, Passed:     3, Skipped:     0, Total:     3, Duration: 737 ms - XtremeIdiots.Portal.Server.Events.Processor.App.Tests.dll (net9.0)

Full unit suite (excluding integration tests, per AGENTS.md):

$ dotnet test src/XtremeIdiots.Portal.Server.Events.slnx --filter "FullyQualifiedName!~IntegrationTests"
Passed!  - Failed:     0, Passed:   380, Skipped:     0, Total:   380, Duration: 1 s - XtremeIdiots.Portal.Server.Events.Processor.App.Tests.dll (net9.0)

Format check

$ dotnet format src/XtremeIdiots.Portal.Server.Events.slnx --verify-no-changes
(no output — exit 0)

Other (lint, terraform plan summary, screenshots)

No Terraform changes in this PR — terraform directory untouched.

Risk and rollout

Blast radius: portal-server-events Processor Function App only (dev + prd). Preventive change; the crash has not yet manifested here because the app has not restarted since PR Implement caching rollout for portal-repo 4.2.21 #52 merged, but any restart / scale event / deploy would trigger it.
Auto-deploys on merge? Follows repo default: deploy-dev on merge to main, prd via the standard release workflow. No new workflow steps.
Manual steps post-merge: None. After deploy to dev, verify the Function App starts cleanly (no ArgumentException: expression must invoke a method declared by IAdminActionsApi in Application Insights traces during host startup) before promoting to prd.
Rollback plan: Revert this commit — restores PR Implement caching rollout for portal-repo 4.2.21 #52 behaviour. Note: reverting reintroduces the startup crash, so rollback is only useful if this change causes an unrelated regression. Repository package version is unchanged, so no NuGet coordination is required either way.

Consumer impact

Reviewer focus areas

Confirm the DI registration in Program.cs still matches the pattern used by every other MX API client in the file (BaseUrl + Entra auth only) — yes.
Confirm the new RepositoryApiClientRegistrationTests exercises real DI resolution (calls .V1 on each versioned facade to force typed-client materialisation) rather than merely inspecting an EnableCaching flag — yes; that is the exact code path where the 4.2.21 policy-composition crash surfaces.
Confirm no other WithCaching / UseLibraryDefaults / CachePolicy call sites remain in the App project — verified by grep.
Coordinated companion fix in portal-sync and portal-repository-func is out of scope for this repo and tracked separately.

Agent attestation

Ran code-review sub-agent; High/Medium findings resolved or justified above in Reviewer focus areas
PR body cites each acceptance criterion from the linked issue
No client secrets, GUIDs, connection strings, or hard-coded subscription IDs introduced (standards.oidc-and-secrets.instructions.md)

…artup crash Repository 4.2.21 client-side caching policy composition throws ArgumentException: expression must invoke a method declared by IAdminActionsApi at DI build time. portal-sync and portal-repository-func are already crashing in production with this signature. portal-server-events main (PR #52) has the same registration and is subject to the same deterministic failure on restart. Removes only `.WithCaching(c => c.UseLibraryDefaults())` from Program.cs. BaseUrl + Entra ID authentication preserved. Repository server-side caching remains active. Player-context IMemoryCache, LiveStatus writes, moderation, VPN protection, welcome messages, and all event handling behaviour unchanged. Repository 4.2.21 / MX.Api 2.3.76 versions unchanged. Adds Startup/RepositoryApiClientRegistrationTests that build the production DI registration and resolve IRepositoryApiClient, IVersionedAdminActionsApi and every sub-client the processor calls at runtime (.V1 access forces the typed-client graph to materialise) so any regression in the AddRepositoryApiClient composition is caught before it reaches production. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>

github-actions · 2026-08-02T21:17:39Z

Dependency Review

✅ No vulnerabilities or license issues or OpenSSF Scorecard issues found.

Scanned Files

None

Copilot

Pull request overview

This hotfix removes consumer-side Repository API client caching configuration from the Processor Azure Functions app to avoid a deterministic startup crash seen in other services on Repository client 4.2.21, while adding a targeted DI-resolution test to ensure typed sub-clients can still be materialized during startup.

Changes:

Removed .WithCaching(c => c.UseLibraryDefaults()) from the Repository API client DI registration in the Processor App.
Added startup DI resolution tests that force versioned sub-client materialization (e.g., AdminActions.V1) to catch future regressions in client composition.

Reviewed changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.

File	Description
src/XtremeIdiots.Portal.Server.Events.Processor.App/Program.cs	Removes consumer-side caching from Repository API client registration to prevent startup crashes.
src/XtremeIdiots.Portal.Server.Events.Processor.App.Tests/Startup/RepositoryApiClientRegistrationTests.cs	Adds DI-resolution tests to ensure Repository client + representative sub-clients resolve at startup.

Suppressed comments (2)

src/XtremeIdiots.Portal.Server.Events.Processor.App.Tests/Startup/RepositoryApiClientRegistrationTests.cs:51

ServiceProvider is IDisposable; this test creates a new provider without disposing it. Use a using declaration to avoid leaking resources across the test run.

        var provider = BuildProductionServiceProvider();

src/XtremeIdiots.Portal.Server.Events.Processor.App.Tests/Startup/RepositoryApiClientRegistrationTests.cs:38

ServiceProvider is IDisposable; this test creates a new provider without disposing it. Use a using declaration to avoid leaking resources across the test run.

        var provider = BuildProductionServiceProvider();

+    [Fact]
+    public void ProductionRegistration_BuildsAndResolvesRepositoryClient()
+    {
+        var provider = BuildProductionServiceProvider();


sonarqubecloud · 2026-08-02T21:20:09Z

Quality Gate passed

Issues
5 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

github-actions · 2026-08-02T21:20:40Z

🏗️ Terraform Plan

🌍 Environment: dev

✅ Validate — Passed

✅ Plan

✅ No changes. Your infrastructure matches the configuration.

…ing (#54) * feat: roll Repository client to 4.2.22 and re-enable consumer L1 caching Bumps XtremeIdiots.Portal.Repository.Api.Client.V1 from 4.2.21 to 4.2.22 and MX.Api.Client from 2.3.76 to 2.3.77. 4.2.22 consumes MX.Api 2.3.77's reflection-free SharedCacheConfiguration which scopes each cache policy to its matching typed sub-API, fixing the cross-sub-API expression fanning bug that crashed startup with 'The expression must invoke a method declared by ...IAdminActionsApi ...' on 4.2.21 (hotfix removed via PR #53). Re-applies '.WithCaching(c => c.UseLibraryDefaults())' on AddRepositoryApiClient that was removed by PR #53. Adds the new mandatory '.WithCachePartition("portal-server-events")' introduced in MX.Api 2.3.77 to isolate this consumer's cache keys. Cache safety verified: the processor's cached surface (library defaults cover GET-shaped reads on GetConfiguration/GetConfigurations, GetProtectedNames, GetAdminActions and Get/HeadPlayer variants) is disjoint from its write surface (Create*/Update*/Set*/Upsert*/Record*/Ensure*/Claim*/Complete*/Consume*). No read-after-write on the same entity in a single Service Bus message handler: HeadPlayerByGameType 404 -> CreatePlayer -> GetPlayerByGameType is a fresh GET (HEAD 404 is not a cached success payload). Configuration/ProtectedNames/AdminAction reads all happen before their respective writes in the same handler. App-owned IMemoryCache player-context is unaffected and still explicitly invalidated after writes. Updates Startup/RepositoryApiClientRegistrationTests to mirror the production registration exactly (both '.WithCachePartition' and '.WithCaching' present) so the smoke test resolves IRepositoryApiClient plus every typed sub-API .V1 the processor uses under the same DI composition path that failed on 4.2.21. Runs under the default CI test filter. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> * refactor: extract Repository client registration into shared helper PR #54 review feedback: the boot smoke test previously duplicated the production Repository client option chain inline, so Program.cs and the test could drift (especially the cache partition literal and the option order). Introduce internal AddPortalServerEventsRepositoryApiClient extension in the App project as the single source of truth for BaseUrl / EntraId audience / cache partition / L1 caching policy. Program.cs and RepositoryApiClientRegistrationTests both call it, so the test is now a real regression guard: any future change to the production chain is exercised by the DI resolution asserts automatically. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> --------- Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>

Copilot AI review requested due to automatic review settings August 2, 2026 21:17

Copilot started reviewing on behalf of frasermolyneux August 2, 2026 21:17 View session

Copilot AI reviewed Aug 2, 2026

View reviewed changes

Comment thread ...ots.Portal.Server.Events.Processor.App.Tests/Startup/RepositoryApiClientRegistrationTests.cs

[Fact]

public void ProductionRegistration_BuildsAndResolvesRepositoryClient()

{

var provider = BuildProductionServiceProvider();

frasermolyneux temporarily deployed to Development August 2, 2026 21:19 — with GitHub Actions Inactive

frasermolyneux merged commit 454644f into main Aug 2, 2026
19 checks passed

frasermolyneux deleted the agents/urgent-hotfix-portal-sync-crash branch August 2, 2026 21:26

frasermolyneux mentioned this pull request Aug 3, 2026

feat: roll Repository client to 4.2.22 and re-enable consumer L1 caching #54

Merged

9 tasks

This was referenced Aug 9, 2026

Bump Microsoft.Azure.AppConfiguration.AspNetCore and 6 others frasermolyneux/portal-servers-integration#1025

Open

Bump the all-updates group with 2 updates frasermolyneux/portal-server-agent#69

Open

Navigation Menu

fix: remove consumer-side Repository client WithCaching to prevent startup crash - #53

fix: remove consumer-side Repository client WithCaching to prevent startup crash#53
frasermolyneux merged 1 commit into
mainfrom
agents/urgent-hotfix-portal-sync-crash

frasermolyneux commented Aug 2, 2026

Uh oh!

github-actions Bot commented Aug 2, 2026

Uh oh!

Copilot AI left a comment

Uh oh!

sonarqubecloud Bot commented Aug 2, 2026

Uh oh!

github-actions Bot commented Aug 2, 2026

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

Conversation

frasermolyneux commented Aug 2, 2026

Summary

Type of change

Required reading consulted

Validation evidence

Build

Tests

Format check

Other (lint, terraform plan summary, screenshots)

Risk and rollout

Consumer impact

Reviewer focus areas

Agent attestation

Uh oh!

github-actions Bot commented Aug 2, 2026

Dependency Review

Scanned Files

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Reviewed changes

Uh oh!

sonarqubecloud Bot commented Aug 2, 2026

Quality Gate passed

Uh oh!

github-actions Bot commented Aug 2, 2026

🏗️ Terraform Plan

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants